Replace test-deal buttons with a Sample deals dropdown - #380
Merged
Merged
Conversation
Collapse the sample deals into one flat toolbar control styled like the other buttons, with a chevron as the only difference. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified; the remaining test-coverage note is a minor nit.
Pull request overview
Replaces three sample-deal buttons with a styled Sample deals… dropdown and updates related tests.
Changes:
- Added dropdown markup and selection handling.
- Applied shared flat toolbar styling with a chevron.
- Updated HTML, unit, and e2e tests.
File summaries
| File | Summary |
|---|---|
web/tests/test_web_html.py |
Validates dropdown markup. |
web/tests/test_web_e2e.py |
Updates browser helpers and scenarios. |
web/tests/dds_web_test.mjs |
Tests selection behavior and styling. |
web/dds_web.js |
Loads samples and resets the placeholder. |
web/dds_web.html |
Replaces sample buttons with dropdown options. |
web/dds_web.css |
Adds shared toolbar styling. |
Review details
Suppressed comments (1)
web/dds_web.js:895
- The new behavior is intended to let a user choose the same sample again after editing, but the added tests only invoke the handler once and assert that the select resets. None of the browser tests selects a sample, edits a hand, and selects that same option again; add that regression case so the user-visible behavior behind this reset is covered.
select.value = "";
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The dropdown resets to its placeholder so the same sample can be chosen again; add unit and e2e coverage for that user-visible behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Addressed the Copilot coverage note: added unit and e2e coverage that loads a sample deal, edits a hand, then selects the same Sample deals option again (depends on resetting the select to the placeholder). |
tameware
added
the
Clean Copilot review
tzimnoch
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
python3 -m unittest web.tests.test_web_htmlnode --test web/tests/dds_web_test.mjsMade with Cursor