-
Notifications
You must be signed in to change notification settings - Fork 121
instrument: TT lookup/hit counters (hot-path) + env-gated summary #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wopdevries
wants to merge
12
commits into
dds-bridge:develop
Choose a base branch
from
wopdevries:wopdevries-tt-hit-rate-instrumentation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+137
−1
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c87c8f7
instrument: TT lookup/hit counters (hot-path) + env-gated summary
a1057b1
fix: reset TT counters per-solve; add add/overwrite counters to PageS…
7bc384c
fix: add includes, reset op_stats per-solve, reset new PageStats fields
00277ea
fix: add get_op_stats and reset_op_stats to MockTransTable
5c165a7
fix: Allman style, strict env var check, doxygen for reset_op_stats
93f4abf
fix: use PRIu64 and avoid string allocation in env var check
3e7a627
fix: remove duplicate include, early reset, safe division in hit_rate
b45d751
fix: add get_op_stats/reset_op_stats to TransTableP after rebase on #368
a9d643c
instrument: add op stats to TransTableP (adds/overwrites)
7a36775
fix: reset stats in solve_same_board; rename overwrites to tightens i…
51054fb
fix: update remaining num_overwrites_ reference to num_tightens_
2ce27db
fix: correct doxygen placement and PatternTT overwrite semantics
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ | |
| #include <api/dds_data_types.hpp> | ||
| #include <moves/moves.hpp> | ||
| #include <string> | ||
| #include <cstdint> | ||
|
|
||
| #ifdef DDS_AB_STATS | ||
| #include "ab_stats.hpp" | ||
|
|
@@ -61,6 +62,12 @@ struct ThreadData | |
| double memUsed; | ||
| int nodes; | ||
| int trickNodes; | ||
| // TT instrumentation (per-context, single-threaded). | ||
| // tt_lookup_count: total TT probe calls on the AB hot path. | ||
| // tt_hit_count: probes that returned a cached result (higher is better). | ||
| // hit_rate = tt_hit_count / tt_lookup_count; target: maximize. | ||
| uint64_t tt_lookup_count = 0; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like to see comments for these two. |
||
| uint64_t tt_hit_count = 0; | ||
|
|
||
| // Constant for a given hand. | ||
| // 960 KB | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.