Take the Tengwar off the texts index - #616
Merged
Merged
Conversation
Every catalogue entry on the shelf index carried its title a second time in Tengwar, beside the method label. The rendering belongs to the work's own page, where a reader who has opened a text meets it once at full size. On the index it repeated seventeen titles nobody had chosen yet and crowded the column that carries the method. The index entries and the book entry drop the rendering, the title helper returns the two halves it now needs, and the three stylesheet rules that dressed the element go with it. Work pages are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The texts index rendered every catalogue title twice: once in romanized Phi at the top of the entry, and again in Tengwar in the meta column beside the method label. Seventeen short works and the book entry each carried one. A reader meets the Tengwar properly on the work's own page, at full size, after choosing the text. On the index it was repetition before the choice, and it crowded the column.
Both index entries lose the rendering. Work pages keep theirs exactly as they were.
Changes
scripts/build_site.pydrops the Tengwar block from the short-work entry and from the News from Nowhere entry, andtext_contents_titlenow returns just the romanized Phi and English halves it needs.site/style.cssloses the three rule blocks that dressed the element: the base rules, the narrow-width overrides, and the print sizing.The helper previously raised if a catalogue title could not render in Tengwar. That check is not lost: each work page renders and validates its own title through the same path, so an unrenderable title still stops the build.
Verification
The site builds.
text-index-entry-tengwarappears nowhere in the deployment tree, andtext-title-tengwaris still present on the work pages.Per the standing rule on site changes, the result was measured rather than assumed. A headless Chrome render of the index at 1280 wide shows the entries reading number, Phi title, English title, summary, method label, arrow, with the meta column intact and no layout collapse. A render of
metta_sutta.htmlconfirms the Tengwar still sits under the English title where it belongs.A narrow render at 420 showed horizontal clipping, which turned out to be a headless artifact rather than a regression: an untouched page, the pamphlets index, clips identically at that width because headless Chrome applies no mobile viewport emulation. The deleted media-query rules styled only the removed element, so no other content could be affected by their absence.
Validator run standalone: 1,287 entries, 0 errors, 0 warnings. No Markdown changed, so the phonetic neighbor baseline is untouched.