Send permission bit fields as decimal, not binary

[mikield]

The bug

Bitwise::getBitSet() returns decbin(), and three payloads send its result straight to Discord:

• CommandBuilder::setDefaultMemberPermissions() → default_member_permissions
• EditPermissionsBuilder::setAllow() → allow
• EditPermissionsBuilder::setDeny() → deny

Discord reads all three as decimal. So asking for ADMINISTRATOR, which is 1 << 3, sends "1000" — and Discord reads that as one thousand:

$b = Bitwise::from(Permission::ADMINISTRATOR);

$b->get();        // 8   — what you asked for
$b->getBitSet();  // "1000" — what was sent
(int) "1000";     // 1000 — what Discord stores

Decimal 1000 is ADMINISTRATOR | MANAGE_GUILD | ADD_REACTIONS | VIEW_AUDIT_LOG | PRIORITY_SPEAKER | STREAM.

Every command registered with default permissions has been granting five permissions nobody asked for, and channel permission overwrites have been allowing and denying the wrong things.

The fix

All three send the decimal value, and the matching getters read it back the same way rather than through fromBitSet.

getBitSet() itself is untouched — a binary representation is a reasonable thing to expose and it has its own test. It just isn't what goes on the wire.

Why it survived

The test asserted the payload equalled getBitSet():

$this->assertEquals($permissions->getBitSet(), $commandBuilder->get()['default_member_permissions']);

That describes the behaviour rather than the requirement, so it passed either way. Both tests now assert the literal value Discord expects.

While there: EditPermissionsBuilderTest built its Bitwise with new Bitwise(1 << 1, 1 << 2, 1 << 3). The constructor takes a single int, so the second and third arguments were silently dropped and the test only ever exercised one flag. It now uses Bitwise::from.

Notes

This is split out of #133 deliberately — it's a small correctness fix against master that stands on its own and is worth releasing without waiting on that larger branch. #133 contains this same commit; whichever merges first, the other rebases cleanly.

composer test (526), composer cs and util/verify-namespacing.sh all pass.