Re-stamp workflow executor_id when successfully checkpointing a step#462
Open
maxdml wants to merge 1 commit into
Open
Re-stamp workflow executor_id when successfully checkpointing a step#462maxdml wants to merge 1 commit into
maxdml wants to merge 1 commit into
Conversation
maxdml
commented
Jul 23, 2026
| config.databaseUrl(), | ||
| config.dbUser(), | ||
| config.dbPassword(), | ||
| createDataSource(config.databaseUrl(), config.dbUser(), config.dbPassword()), |
Contributor
Author
There was a problem hiding this comment.
@devhawk it looks like there might be a pre-existing issue where this path would ignore config.useListenNotify()
Collaborator
There was a problem hiding this comment.
You mean in the else clause? yeah, looks like an issue. If you want to fix it here, go ahead. Otherwise please open an issue
devhawk
reviewed
Jul 24, 2026
Comment on lines
+120
to
133
| if (won && executorId != null) { | ||
| String updateSql = | ||
| """ | ||
| UPDATE "%s".workflow_status SET executor_id = ? WHERE workflow_uuid = ? AND executor_id IS DISTINCT FROM ? | ||
| """ | ||
| .formatted(schema); | ||
| try (var stmt = conn.prepareStatement(updateSql)) { | ||
| stmt.setString(1, executorId); | ||
| stmt.setString(2, result.workflowId()); | ||
| stmt.setString(3, executorId); | ||
| stmt.executeUpdate(); | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
this seems like it should be a static method on workflowDAO
devhawk
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an executor "wins" the checkpointing race, it should restamp the executor ID column in the status table so reporting is accurate.