dbeaver/pro#10322 use svg as indicator to fix off center issue - #4601
Open
devnaumov wants to merge 1 commit into
Open
dbeaver/pro#10322 use svg as indicator to fix off center issue#4601devnaumov wants to merge 1 commit into
devnaumov wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes 10322
The issue occurred at page zoom levels below 100% because the outer ring and inner dot were rendered as separate CSS elements and rounded to physical pixels independently. At fractional zoom levels, this caused the dot to appear off-center. A radial-gradient fixed the alignment but reduced sharpness at the default zoom level.
The indicator now uses a single SVG where the ring and dot share the same viewBox and center. This keeps the indicator aligned at fractional zoom levels, preserves sharp rendering at 100%, and supports the component’s existing sizes.