Don't wait for Boundary tunnel teardown on quit - #2271
Merged
Merged
Conversation
At /quit, mycli was waiting up to a couple of seconds to tear down the Boundary connection, and the logic allowed for an even longer wait. Instead we should just exit, and let the terminated Boundary process take care of itself. Other tunnel mechanisms (SSH and kubectl) are left untouched, since their teardown is faster in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At
/quit, mycli was waiting up to a couple of seconds to tear down the Boundary connection, and the logic allowed for an even longer wait.Instead we should just exit, and let the terminated Boundary process take care of itself.
Other tunnel mechanisms (SSH and kubectl) are left untouched, since their teardown is faster in practice.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).