Ensure user is logged in to Vault - #2105
Merged
Merged
Conversation
before trying to read credentials from Vault, and raise with a specific
error message if not.
This could probably be refined for more cases, such as the lack of a
connection.
We assume that all exit codes represent an error, though Vault has a
habit of encoding information into different exit codes.
The test command is
vault taken lookup -format=json
though any JSON output is currently not parsed.
We use functools to ensure that the check is only performed once, though
"vault kv" could be run twice: once for the username and once for the
password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure user is logged in to Vault before trying to read credentials from Vault, and raise with a specific error message if not.
This could probably be refined for more cases, such as the lack of a connection.
We assume that all exit codes represent an error, though Vault has a habit of encoding information into different exit codes.
The test command is
though any JSON output is currently not parsed.
We use
functoolsto ensure that the check is only performed once, thoughvault kvcould be run twice: once for the username and once for the password.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).