Repository navigation
fix(workers): close the registry's OpenSearch client at shutdown - #326
Closed
davidamacey wants to merge 1 commit into
Closed
davidamacey wants to merge 1 commit into
davidamacey wants to merge 1 commit into
Conversation
Owner
Author
|
Folded into #329 (merge commits preserved) to avoid repeated full CI runs and changelog conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auto-label, cluster-refresh and VLM workers opened a second OpenSearch client for their project registry that nothing closed, so shutdown logged
Unclosed client session(found in the #235/#236 live check).script_project_registrynow takes the worker's own client, which each worker already closes.Test: registry reads through the caller's client (seen failing before the change). Targeted worker suites: 282 passed. Hooks clean.