Conversation
Fifty DNSRecordSetNotAccepted alerts render the same sentence, so nobody reading them can tell which records are stuck or how many distinct ones there are. The rule already carries the record name and the owning project as labels, and Slack shows only the summary, which names neither. Normalise the project label onto `proj` the way the recording rules already do, then name the record and the project in the summary. The metric reaches the datasource under two spellings depending on the ingest path, so the alert takes the same dual-spelling branch the recording rules use rather than assuming one. Verified against staging: the expression returns 62 series, each carrying a distinct `proj` and `name`, where the previous summary rendered 50 identical lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fifty stuck DNS record sets alert with the same sentence, so nobody reading the channel can tell which customer records are affected or how many distinct ones there are.
The rule already carries the record name and the owning project as labels. Slack shows only the summary, which names neither.
This names both in the summary, and normalises the project label the way the sibling recording rules already do.
Test plan
Fixes #159