feat: add Page, Topic, and Twins Post content types - #17
Merged
Merged
Conversation
Adds new collection types for the Twins in the Loop site: static Pages, Topic taxonomy, and Twins Post blog entries with a dedicated twins-post.seo component for Open Graph/SEO metadata. Includes a migration script to import existing Twins posts and a seed script for topics. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Edo <aria.edo@gmail.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The new CLI scripts should ensure Strapi is always destroyed on failure and should validate required source paths to avoid generic runtime crashes.
Review details
Suppressed comments (2)
Previously missed (2) — in code that hasn't changed since the last review.
scripts/migrate-twins-post.js:164
fs.readdirSync(POSTS_SOURCE)will throw a generic ENOENT if the source directory is missing, and ifmigrate(app)throws,app.destroy()is skipped because it isn't in afinallyblock. ValidatePOSTS_SOURCEup front and ensure Strapi is always destroyed viatry/finally.
scripts/seed-topics.js:44maincallsprocess.exit(0)on the success path, but ifseedTopics(app)throws,app.destroy()is skipped because it's not in afinallyblock. Wrap the seeding call intry/finallyso the Strapi instance is always destroyed before exiting.
- Files reviewed: 18/20 changed files
- Comments generated: 0 new
- Review effort level: Lite
felixwidjaja
self-requested a review
September 10, 2026 10:31
felixwidjaja
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pagecollection type for static Twins in the Loop pagesTopiccollection type as taxonomy for Twins Post entriesTwins Postcollection type for Twins in the Loop blog content, with a dedicatedtwins-post.seocomponent (ogTitle,ogDescription,ogImage,ogType,keywords) instead of flat top-level fieldsscripts/migrate-twins-post.jsto import existing Twins posts andscripts/seed-topics.jsto seed topicsPROJECT_ANALYSIS.mdto document the new content types and componentTest plan
strapi develop) — booted cleanly with no schema errorsGET /admin→ 200)seo: Schema.Attribute.Component<'twins-post.seo', false>🤖 Generated with Claude Code