feat: add autoscale settings to datumctl compute - #295
Open
savme wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CPU/memory-based autoscaling to
deployandscaleindatumctl, and surfaces it inworkloads describe.Deploy with autoscaling from the start:
Turn autoscaling on or adjust it on an existing workload, without redeploying:
See what's configured:
Notes:
scale api --max=5on an autoscaled workload doesn't reset its CPU targetdeploywarns before collapsing them into one (flags produce only a single placement)Test plan
datumctl compute scaleanddatumctl compute deploytested