fix(webhook): stop attaching an instance's first interface twice - #29
Merged
Merged
Conversation
The pod webhook set v1.multus-cni.io/default-network to the first interface and also listed it in k8s.v1.cni.cncf.io/networks, so Multus attached the same NAD as eth0 and net1. Only the remaining interfaces are now listed, and the networks annotation is omitted when there are none. Closes #28 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SYmkahHLMsqf3f8DYcsRaQ
ecv
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pods with injected interfaces no longer get their first interface attached twice. The webhook named it in
v1.multus-cni.io/default-networkand also listed it ink8s.v1.cni.cncf.io/networks, so Multus attached the same NAD aseth0andnet1with the same IP, and paid a second galactic ADD (~0.25s per pod on the staging Kata node).Closes #28
k8s.v1.cni.cncf.io/networksnow carries only the instance's remaining interfaces, plus anything the Pod already asked for. A single-interface instance gets no networks annotation.🤖 Generated with Claude Code
https://claude.ai/code/session_01SYmkahHLMsqf3f8DYcsRaQ