Skip to content

Download only bundle artifacts when releasing - #184

Merged
ecv merged 1 commit into
mainfrom
ci/release-artifact-filter
Sep 11, 2026
Merged

Download only bundle artifacts when releasing#184
ecv merged 1 commit into
mainfrom
ci/release-artifact-filter

Conversation

@ecv

@ecv ecv commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Releasing the desktop app fails at the last step, after all four platform bundles have already built. Users get no release, and the four builds are thrown away.

The release job collects every artifact the run produced, which sweeps in build metadata from the container job that the release has no use for and cannot unpack. This limits the collection to the platform bundles the release publishes.

Test plan

  • Reproduced twice on the same run, once on the original dispatch and once on a rerun of the failed job, so it is not a flake
  • Confirmed all four bundle jobs and the container job succeed, and only the final job fails
  • Confirmed no tag or release object is left behind by the failure
  • Redispatch the release after this merges and confirm assets attach

https://claude.ai/code/session_01T2Bmcs7qWPaw1R6HnmrmBq

The release job downloaded every artifact in the workflow run. That set
includes the buildx metadata the container job uploads, whose name
carries tildes and which the release job has no use for. Extracting it
fails, and the download action gives up after five retries, so the whole
release fails after all four platform bundles have already built.

This is not a flake. It failed identically on the first run and on a
rerun of the failed job.

Filter the download to the platform bundles the release actually
publishes. The container image is published by its own job and reaches
users through the registry, not through release assets.

Claude-Session: https://claude.ai/code/session_01T2Bmcs7qWPaw1R6HnmrmBq
@ecv
ecv requested a review from kevwilliams September 10, 2026 20:45

@kevwilliams kevwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern DatumConnect-* correctly matches the three bundle artifacts uploaded by the bundle job (DatumConnect-Linux, DatumConnect-macOS, DatumConnect-Windows) and excludes the buildx metadata artifact from the container job, consistent with the existing DatumConnect-macOS reference in bundle.yml. Single-line workflow change, no stray files, and the commit message clearly explains the root cause and reproduction. Good to go.

@ecv
ecv merged commit bb8c709 into main Sep 11, 2026
5 checks passed
@ecv
ecv deleted the ci/release-artifact-filter branch September 11, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants