Repository navigation
ci: 243 unit testing added to cicd pipeline - #246
Open
frayle-ons wants to merge 3 commits into
Open
frayle-ons wants to merge 3 commits into
frayle-ons wants to merge 3 commits into
Conversation
frayle-ons
marked this pull request as ready for review
October 16, 2026 18:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Summary
These changes add unit test testing into the CI GitHub actions workflow. Specifically, the unit test checks now run as part of the
lint-testjob that is conditioned to run only when a PR's status is set as 'ready for review' (and all all subsequent updates to the ready for review PR).The exact change was very small, adding an additional line of code to the ci.yml file. The addition of the
--extra allflag ensures all necessary optional dependencies are installed for the unit tests:I've also commented out 1 of the GCP_Vectoriser unit tests, which is likely failing due to recent updates to the GCP Vectoriser kwargs, see #233
📜 Changes Introduced
✅ Checklist
Changes pass all configured pre-commit steps
🔍 How to Test
Start by checking out the branch that corresponds to this PR. Then create your own PR, saving it as draft and viewing the CI jobs that run. It should show that
lint-testis skipped. Following this, convert the test PR to ready for review and observe that the skipped job does run. Inspecting the drop down, see that the unit tests do indeed run as part of the CI step.If you uncomment the failing unit test, seen in the code changes of this PR, you can see the downstream effect of pushing this change to remote has. Confirm that this action does cause the CI testing to fail the
lint-testjob and that the cause is the failed unit test.