fix(runtime): authorize native group sandbox execution - #967
Merged
Conversation
Native group Sessions are intentionally shared and therefore have no owning Agent. Authorize their sandbox scope through the active tenant Group and active Agent participant membership while preserving exact ownership for Direct and external-channel Sessions. Constraint: Native group Sessions intentionally have chat_sessions.agent_id NULL Rejected: Backfill a group Session Agent | shared Sessions can host multiple Agents Rejected: Allow every group Session | would bypass tenant Group and active membership checks Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep Direct and external-group exact Agent ownership checks intact Tested: 155 scoped DAO, group chat, Runtime, Sandbox, subprocess, and workspace tests Tested: Ruff passed for changed DAO and policy test files Not-tested: 3010 live group execution before deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Release
P0 hotfix targeting v1.11.4. No database migration.