add the use_config_threshold_for_spanner_embedding feature flag to prod following the flag for other env setup - #6548
Conversation
…od following the flag for other env setup
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature flag to the production environment to control the threshold logic for Spanner embeddings. By gating this functionality, the team can safely toggle between the hardcoded default threshold and a configurable value based on recent testing results. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new feature flag configuration 'use_config_threshold_for_spanner_embedding' to the production environment, which is initially disabled. This flag gates the use of the 'SPANNER_EMBEDDING_THRESHOLD' configuration. There are no review comments, and I have no feedback to provide.
gmechali
left a comment
There was a problem hiding this comment.
Can you ping us when your PR made it to production github.com//pull/6533
So we can approve this then. A bit too early for this PR :)
|
Please conduct a careful review before merging this production change & coordinate with the oncaller. Things to check before approving:
|
This PR add the feature flag in prod environment and default to false
When false, we will read default value 0.7 from the code,
When true, we will set config value to be 0.6 based on test result https://docs.google.com/spreadsheets/d/12d9BPJagWS5z2WA8En9JY71TyGrCYpIBQ4LqI0JJ2v4/edit?gid=1132426848#gid=1132426848