Skip to content

Implement Context Menu Overrides w/ Font Family Fix#369

Open
PauloMFJ wants to merge 3 commits into
datacommonsorg:mainfrom
madebypxlp:paulo/context-menu-overrides
Open

Implement Context Menu Overrides w/ Font Family Fix#369
PauloMFJ wants to merge 3 commits into
datacommonsorg:mainfrom
madebypxlp:paulo/context-menu-overrides

Conversation

@PauloMFJ

Copy link
Copy Markdown
Contributor

Before

Right click without selected card(s):
image

Right click with selected card:
image

Right click with selected cards:
image

After

Right click without selected card(s):
image

Right click with selected card:
image

Right click with selected cards:
image

@PauloMFJ PauloMFJ self-assigned this Jun 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors typography styling by setting a global default font-family on the html element and removing redundant font-family declarations from typography mixins. It also overrides tldraw's default context menu and disables several unsupported actions (such as exporting, copying, and page movement). The feedback suggests explicitly setting form controls to inherit the font family, as they do not inherit from html by default, and using standard system fallbacks for serif and monospace fonts in tldraw instead of mapping them to the sans-serif "Google Sans" font.

Comment thread dataweaver/apps/web/src/styles/core/_base.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant