Implement Context Menu Overrides w/ Font Family Fix#369
Open
PauloMFJ wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors typography styling by setting a global default font-family on the html element and removing redundant font-family declarations from typography mixins. It also overrides tldraw's default context menu and disables several unsupported actions (such as exporting, copying, and page movement). The feedback suggests explicitly setting form controls to inherit the font family, as they do not inherit from html by default, and using standard system fallbacks for serif and monospace fonts in tldraw instead of mapping them to the sans-serif "Google Sans" font.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Right click without selected card(s):

Right click with selected card:

Right click with selected cards:

After
Right click without selected card(s):

Right click with selected card:

Right click with selected cards:
