You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a promotion mechanism to stable releases. It adds a promote.sh script to promote a specified version to 'stable' in the Artifact Registry, updates the default _PROD_TAG in cloudbuild.yaml to latest, and documents the promotion process in the README. Feedback on the new script includes adopting set -euo pipefail for more robust error handling and double-quoting variables to prevent word splitting.
The reason will be displayed to describe this comment to others. Learn more.
It is a best practice to use set -u (to exit on undefined variables) and set -o pipefail (to prevent errors in pipelines from being masked) along with set -e for more robust error handling in Bash scripts.
The reason will be displayed to describe this comment to others. Learn more.
Variables should be double-quoted to prevent word splitting and globbing, especially when they are user-controlled or environment-provided (like $PROJECT_ID and $VERSION). This ensures the script behaves correctly even if these variables contain spaces or special characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stabletag