OECDRegionalDemography_Population| Fixed missing data issue - #2152
OECDRegionalDemography_Population| Fixed missing data issue#2152Ashwani725 wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces new statistical variables for age groups 20-64, 25-54, and 55-64, including gender-specific breakdowns, and updates the associated column mappings and golden data. Additionally, a new validation configuration file is added to the manifest. The reviewer recommended updating the rule_id in the validation configuration for consistency and noted that the expected test files must be updated to reflect these schema changes to prevent unit test failures.
Fixed missing data and refresh failures in OECDRegionalDemography_Population caused by upstream OECD schema updates from 2024 onwards. The source dataset introduced new working-age demographic cohorts (Y20T64, Y25T54, and Y55T64), which were previously unmapped and dropped during preprocessing. This PR adds 9 new Statistical Variable mappings for total, male, and female demographics across these age brackets in columns.py, defines their corresponding dcs:StatisticalVariable schema nodes in OECD_population_stat_vars.mcf
files changed are: OECD_population_stat_vars.mcf, columns.py, manifest.json, golden_data/, validation_config.json