-
Notifications
You must be signed in to change notification settings - Fork 155
India_LifeExpectancy | Added_goldens #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ashwani725
wants to merge
8
commits into
datacommonsorg:master
Choose a base branch
from
Ashwani725:added_goldens
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−4
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
aa850ba
added goldens
ce1bc84
Merge branch 'master' into added_goldens
Ashwani725 7505881
Rename rule_id to check_goldens_output_csv
Ashwani725 a8c476d
Update manifest.json to include output counters
Ashwani725 30d0c6a
adding counters in manifest.json
Ashwani725 823d4f7
Merge branch 'master' into added_goldens
Ashwani725 8142de2
Update manifest.json
Ashwani725 4565f35
Merge branch 'master' into added_goldens
Ashwani725 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
22 changes: 22 additions & 0 deletions
22
statvar_imports/india_ndap/ndap/golden_data/golden_observations.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| "observationAbout" | ||
| "wikidataId/Q1177" | ||
| "wikidataId/Q22424" | ||
| "wikidataId/Q1499" | ||
| "wikidataId/Q1174" | ||
| "wikidataId/Q1353" | ||
| "wikidataId/Q1437" | ||
| "wikidataId/Q1498" | ||
| "wikidataId/Q1165" | ||
| "wikidataId/Q1164" | ||
| "wikidataId/Q1356" | ||
| "wikidataId/Q1184" | ||
| "wikidataId/Q22048" | ||
| "wikidataId/Q1168" | ||
| "wikidataId/Q1188" | ||
| "wikidataId/Q1061" | ||
| "wikidataId/Q1191" | ||
| "wikidataId/Q1159" | ||
| "wikidataId/Q1185" | ||
| "wikidataId/Q1186" | ||
| "wikidataId/Q1445" | ||
| "wikidataId/Q677037" | ||
4 changes: 4 additions & 0 deletions
4
statvar_imports/india_ndap/ndap/golden_data/golden_summary_report.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "MeasurementMethods","Units","ScalingFactors","NumPlaces","StatVar","observationPeriods","MinDate" | ||
| "[]","[Year]","[]","21","LifeExpectancy_Person_Male","[P4Y]","1997" | ||
| "[]","[Year]","[]","21","LifeExpectancy_Person_Female","[P4Y]","1997" | ||
| "[]","[Year]","[]","21","LifeExpectancy_Person","[P4Y]","1997" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "schema_version": "1.0", | ||
| "rules": [ | ||
| { | ||
| "rule_id": "check_deleted_records_percent", | ||
| "description": "Checks that the percentage of deleted points is within the threshold.", | ||
| "validator": "DELETED_RECORDS_PERCENT", | ||
| "params": { | ||
| "threshold": 0.1 | ||
| } | ||
| }, | ||
| { | ||
| "rule_id": "check_goldens_summary_report", | ||
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": "../../../../golden_data/golden_summary_report.csv" | ||
| } | ||
| }, | ||
| { | ||
| "rule_id": "check_goldens_output_csv", | ||
| "description": "Verifies the generated output CSV data matches established critical golden records", | ||
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": "../../../../golden_data/golden_observations.csv", | ||
| "input_files": "../../../../output/India_LifeExpectancy.csv" | ||
| } | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.