Fix import issue in differ#2074
Merged
vish-cs merged 1 commit intoJun 17, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the dataset differ utility to output MCF diff files and a consolidated JSON summary instead of CSV files, and updates the import validation runner to parse these new formats. It also introduces a new direct runner mode using a Java bundle. The code review feedback highlights a few areas of improvement: resolving a potential data loss bug in write_mcf_nodes where dcid properties could be omitted, replacing fragile string checks for 'nan' with robust pd.isna() calls, and making the MCF parser in the validation runner more resilient to arbitrary spacing around colons.
vish-cs
force-pushed
the
revert-file-util-import-and-fix-differ
branch
from
8e532c0 to
b293f41
Compare
vish-cs
force-pushed
the
revert-file-util-import-and-fix-differ
branch
from
b293f41 to
0c812fa
Compare
kartik-s21
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert import changes to file_util.py and handle in differ_utils.py instead.