Repository navigation
[PureGo] Add per-stream connections - #897
Merged
Merged
Conversation
danilonajkov-db
changed the title
danilonajkov-db
force-pushed
the
effort/connection-mux
branch
2 times, most recently
from
October 5, 2026 15:34
c767b8a to
8f9b032
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: danilo-najkov-db <danilo.najkov@databricks.com>
danilonajkov-db
force-pushed
the
effort/connection-mux
branch
from
October 7, 2026 11:40
8f9b032 to
44fdb05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Issue #767 shows that PureGo's shared gRPC connection limits throughput when one SDK owns several ingestion streams. Add
WithConnectionPerStream(enabled), matching the Rust and wrapper SDKs: each stream gets a dedicated gRPC connection by default, andWithConnectionPerStream(false)multiplexes all streams from an SDK over one shared connection.Dedicated connections belong to their streams and close on stream teardown, including failed opens and
SDK.Close. The shared connection belongs to the SDK and closes after its streams. The README and changelog explain the new option.This follows the connection isolation direction explored in #821. Addresses #767.
How is this tested?
cd purego && go test ./...cd purego && go test -race ./zerobus -run TestConnectionPerStreamModes -count=1The local gRPC integration test checks that four streams use four TCP connections by default and one shared TCP connection when the option is false. It also verifies that closing one stream leaves another able to ingest and flush.