Repository navigation
[Rust] Expose persistent stream API - #763
Merged
Merged
Conversation
This was referenced Aug 20, 2026
elenagaljak-db
force-pushed
the
stack/eos-grpc-core
branch
from
August 20, 2026 09:27
98b4072 to
9dcabe6
Compare
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
from
August 20, 2026 09:27
3f681ec to
793df75
Compare
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
from
August 20, 2026 10:47
793df75 to
ae4347c
Compare
elenagaljak-db
force-pushed
the
stack/eos-grpc-core
branch
2 times, most recently
from
August 20, 2026 13:09
18a643f to
abf5a92
Compare
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
from
August 20, 2026 13:09
ae4347c to
e7effcb
Compare
elenagaljak-db
force-pushed
the
stack/eos-grpc-core
branch
from
August 24, 2026 16:40
abf5a92 to
12c4957
Compare
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
from
August 25, 2026 12:36
e7effcb to
ef1b17e
Compare
elenagaljak-db
force-pushed
the
stack/eos-grpc-core
branch
from
August 25, 2026 13:48
a574b4e to
137f398
Compare
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
3 times, most recently
from
August 28, 2026 16:41
0ecfe35 to
c202abf
Compare
elenagaljak-db
force-pushed
the
stack/eos-grpc-core
branch
from
August 28, 2026 17:27
4726b61 to
7a5f026
Compare
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
from
August 28, 2026 17:27
c202abf to
450ef0f
Compare
elenagaljak-db
force-pushed
the
stack/eos-grpc-core
branch
from
September 24, 2026 12:42
7a5f026 to
6efa8f1
Compare
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
2 times, most recently
from
September 25, 2026 14:03
8a1eda0 to
c722ab2
Compare
elenagaljak-db
force-pushed
the
stack/eos-grpc-core
branch
from
September 25, 2026 14:49
d99bc86 to
8934b9f
Compare
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
from
September 25, 2026 14:50
c722ab2 to
c9e7b71
Compare
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
from
September 25, 2026 16:06
c9e7b71 to
f6e23ab
Compare
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
2 times, most recently
from
October 2, 2026 14:16
f4ee1e6 to
17f6734
Compare
Signed-off-by: elenagaljak-db <elena.galjak@databricks.com>
elenagaljak-db
force-pushed
the
stack/eos-public-api
branch
from
October 2, 2026 15:53
17f6734 to
ef342eb
Compare
teodordelibasic-db
approved these changes
Oct 3, 2026
teodordelibasic-db
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, couple of follow ups/nits.
| pub(crate) async fn prepare_grpc( | ||
| mut self, | ||
| ) -> ZerobusResult<( | ||
| crate::databricks::zerobus::zerobus_client::ZerobusClient<tonic::transport::Channel>, |
Collaborator
There was a problem hiding this comment.
Can be a follow up, but it would be probably be cleaner to have a structure/type alias containing all of this.
Collaborator
Author
There was a problem hiding this comment.
I will fix all of these in the next pr
| pub(crate) async fn prepare_grpc( | ||
| mut self, | ||
| ) -> ZerobusResult<( | ||
| crate::databricks::zerobus::zerobus_client::ZerobusClient<tonic::transport::Channel>, |
Collaborator
There was a problem hiding this comment.
Also a nit, but I am personally not a fan of these fully qualified names, we can import them at the top of the file.
| /// let stream = builder.build().await?; | ||
| /// ``` | ||
| #[must_use = "a StreamBuilder does nothing until `.build()` is called"] | ||
| pub struct StreamBuilder<'a> { |
Collaborator
There was a problem hiding this comment.
Also a nit and a follow up, but we can extract the ephemeral specific constructs into a separate file and leave only common stuff in here.
elenagaljak-db
added a commit
that referenced
this pull request
Oct 6, 2026
Replace the tuple that prepare_grpc returns with a crate-private GrpcStreamParts struct, and import ZerobusClient and Channel instead of using fully qualified paths. Addresses review nits on #763. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: elenagaljak-db <elena.galjak@databricks.com>
elenagaljak-db
added a commit
that referenced
this pull request
Oct 6, 2026
Move StreamBuilder::build into stream_builder/ephemeral.rs, and move multiplexed() and multiplexed_ack_callback() into multiplexed.rs, so mod.rs keeps the builder state and the setters that the persistent builder also uses. No public API or behavior change. The Arrow Flight setters and build_arrow() stay in mod.rs until the Arrow mux work in #866 lands. Addresses a review nit on #763. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: elenagaljak-db <elena.galjak@databricks.com>
elenagaljak-db
added a commit
that referenced
this pull request
Oct 16, 2026
Replace the tuple that prepare_grpc returns with a crate-private GrpcStreamParts struct, and import ZerobusClient and Channel instead of using fully qualified paths. Addresses review nits on #763. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: elenagaljak-db <elena.galjak@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR exposes the feature-gated Rust API for creating and resuming persistent streams on top of #762.
It adds:
ZerobusSdk::persistent_stream_builder().PersistentStreamBuilderwith the existing table, authentication, format, recovery, timeout, backpressure, and callback configuration.build()for a new durable stream andresume(stream_id)for reconnecting.PersistentStream, exposingstream_id, the resume watermark, ingestion, batch ingestion, flush, offset waiting, close, and unacknowledged-record retrieval.JSON and protobuf are supported; Arrow Flight and a public retirement API are intentionally deferred. Documentation follows the pipelined loop-then-
flush()pattern. The new public feature is recorded inrust/NEXT_CHANGELOG.md.Stack
How is this tested?
cargo check -p databricks-zerobus-ingest-sdk --features eoscargo test -p databricks-zerobus-ingest-sdk --features eos --lib— 156 tests passedcargo fmt --all -- --check