Repository navigation
Use Codex's OAuth client for MCP when the workspace doesn't advertise CIMD - #1338
Open
andy-xu-db wants to merge 1 commit into
Open
andy-xu-db wants to merge 1 commit into
andy-xu-db wants to merge 1 commit into
Conversation
… CIMD Codex desktop labels stdio MCP servers "Auth unsupported". Workspaces that recognize Codex's published client but don't advertise CIMD metadata fell back to the proxy; use the URL + OAuth entry for Codex whenever the client probe passes. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Codex desktop app shows
ug's MCP servers as "Auth unsupported". Codex uses that label for every stdio server, andugwrites the stdioug mcp-proxyentry. Since #1257,ugwrites the native URL + OAuth entry only when the workspace advertisesclient_id_metadata_document_supported. Workspaces such aseng-ml-inference.staginganddbc-a5d4177a-49dcdon't advertise it, even though they accept Codex's published client (https://chatgpt.com/oauth/codex/client.json).With this change, Codex skips the advertisement check. It still needs the existing
oauth_client_availabletoken-endpoint probe to pass, and the service still has to be connection-backed. Claude and Cursor are unchanged, and so are PAT and unknown-client fallbacks, which still use the proxy.Testing
eng-ml-inference.staging: I hand-wrote a URL + OAuth entry with the Codex client and rancodex mcp login. The browser sign-in completed.uv run pytest tests/test_mcp.py tests/test_agent_codex.py tests/test_mcp_oauth.pypasses. Cursor keeps its test that requires the advertisement, and Codex gets a new test that skips it.just lintpasses. In the full suite, 12 tests fail. 11 of them also fail on unchanged main (test_agents_initrequired-update,test_e2e_user_agent,test_smart_router). The 12th, one run oftest_launcher_flags_control_routing_hook, passed when I reran it on main.This pull request and its description were written by Isaac.