Introduce ug command and Phase 1 migration path - #458
Conversation
6eb4410 to
bed2212
Compare
| workspace=workspace, | ||
| profile=profile, | ||
| command_label="Configure Unity Gateway", | ||
| command_label="Configure ug", |
There was a problem hiding this comment.
leave as Configure Unity Gateway ?
There was a problem hiding this comment.
Configure ug sounded better ? Configure Unity Gateway sounded weird ? thats the whole product
There was a problem hiding this comment.
Configure unity-gateway?
| workspace=workspace, | ||
| profile=profile, | ||
| command_label="Configure Unity Gateway", | ||
| command_label="Configure ug", |
There was a problem hiding this comment.
Configure unity-gateway?
| f"{f': {detail}' if detail else '.'}" | ||
| ) | ||
| print_note("The existing installation was left unchanged.") | ||
| raise typer.Exit(1) |
There was a problem hiding this comment.
not 100% sure about the difference between this and
raise typer.Exit(1) from None
which seems to be used more widely below
There was a problem hiding this comment.
agent telling me this is ok, but
typer.Exit subclasses RuntimeError, so this gets caught by the except RuntimeError below and adds a trailing ERROR 1 after the real error. Minor, but an except typer.Exit: raise before that handler would avoid it.
| print_note("The existing installation was left unchanged.") | ||
| raise typer.Exit(1) | ||
|
|
||
| _verify_upgraded_commands() |
There was a problem hiding this comment.
nit: i think this should only be ran if migrated is true?
3 participants
Summary
ugconsole entry point while retainingucodeas a supported aliasug, while preserving Unity Gateway branding in agent launch banners and Smart Router noticesug upgradedistribution-aware: upgradeucodenormally before cutover, migrate only on uv's confirmed metadata-name mismatch, then upgradeunity-gatewaynormally afterwarduganducodeafter every successful upgradeTesting
.venv/bin/pytest tests/test_cli.py tests/test_entry_points.py -q(284 passed).venv/bin/ruff check ..venv/bin/ruff format --check src/ucode/cli.py tests/test_cli.py.venv/bin/ty check src/ucode/cli.pygit diff --checkucodemetadata mismatch at cutover, successful reinstall asunity-gateway, and normal post-cutoveruv tool upgrade unity-gatewayRelease requirement
Merge and tag this commit while
[project].nameis stillucode. That immutable tag is the bridge release and must exist before the distribution-name cutover.