fix: reject NaN results from arithmetic operations#914
Closed
He-Pin wants to merge 2 commits into
Closed
Conversation
Motivation: std.primitiveEquals(-0.0, 0.0) was returning false instead of true. This is incorrect because IEEE 754 defines -0.0 == 0.0 as true. Modification: Changed TypeModule.scala to use rawDouble == rawDouble for number comparison instead of ev.compare(x, y) == 0 which uses java.lang.Double.compare that treats -0.0 and 0.0 as different. Result: std.primitiveEquals(-0.0, 0.0) now returns true, matching go-jsonnet and C++ jsonnet behavior. References: - go-jsonnet builtins.go:264 uses left.value == right.value - C++ Jsonnet vm.cpp:1436 uses args[0].v.d == args[1].v.d
- Add NaN check to division and modulo operations - Match go-jsonnet behavior: 'Not a number' error for NaN results - Match go-jsonnet behavior: 'Division by zero.' error for modulo by zero - Fixes inconsistency with go-jsonnet where 0.0/0.0 returned NaN instead of erroring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix NaN handling in arithmetic operations to match go-jsonnet behavior.
Problem
sjsonnet was inconsistent with go-jsonnet for NaN-producing operations:
0.0 / 0.00.0 % 0.01.0 % 0.0Changes
Evaluator.scala
Division (
/): Added NaN check after divisionModulo (
%): Added zero check and NaN checkInline arithmetic fast path: Added NaN checks to
tryInlineArithReferences
builtins.go:1108:makeDoubleCheckfunction checks both NaN and Infinitybuiltins.go:117-120: Division checksy.value == 0before computingbuiltins.go:132-135: Modulo checksy.value == 0before computingTest
All existing tests pass. The fix ensures sjsonnet behaves identically to go-jsonnet for arithmetic edge cases.