fix: correct std.repeat error message#906
Merged
stephenamar-db merged 2 commits intoJun 9, 2026
Merged
Conversation
He-Pin
force-pushed
the
fix/repeat-error-message
branch
from
ba251f4 to
3ed4072
Compare
He-Pin
commented
Jun 9, 2026
| builtin("repeat", "what", "count") { (pos, ev, what: Val, count: Int) => | ||
| if (count < 0) { | ||
| Error.fail("makeArray requires size >= 0, got " + count) | ||
| Error.fail("repeat requires count >= 0, got " + count) |
stephenamar-db
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std.repeaterror message from "makeArray requires size >= 0" to "repeat requires count >= 0"std.makeArrayVerification against go-jsonnet
go-jsonnet shows "makeArray requires size >= 0" because its stdlib implements
std.repeatin Jsonnet usingstd.makeArrayinternally. sjsonnet implementsstd.repeatas a native builtin, so the error should reference the correct function name that the user called.Test plan
error.repeat_negative_count.jsonnet