fix: include line number in std.trace output - #1101
Merged
Merged
Conversation
Motivation: std.trace output was missing the line number, diverging from all other Jsonnet implementations (go-jsonnet, jrsonnet, C++ jsonnet) which all emit "TRACE: <file>:<line> <msg>". sjsonnet only emitted "TRACE: <file> <msg>". Modification: Use the existing EvalErrorScope.prettyIndex infrastructure to resolve the position offset to a line number and include it in the trace output format. Result: std.trace now outputs "TRACE: <file>:<line> <msg>", consistent with the official documentation example and all reference implementations.
stephenamar-db
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std.tracenow outputsTRACE: <file>:<line> <msg>instead ofTRACE: <file> <msg>EvalErrorScope.prettyIndexinfrastructure to resolve line numbersMotivation
All other Jsonnet implementations include the line number in trace output:
TRACE: test.jsonnet:3 helloTRACE: test.jsonnet:3 helloTRACE: test.jsonnet:3 helloTRACE: test.jsonnet:3 cond is true returning {"b": true}sjsonnet was the only implementation omitting it, making trace output less useful for debugging.
Test plan
trace.jsonnet,comprehension_no_unsafe_hoist_trace.jsonnet,lazy_array_reverse_cache_trace.jsonnetEvaluatorTeststrace assertionssjsonnet.jvm.2_13_18.test)