test: [ci] Pin integration runs to reviewed commit SHA#1598
Merged
Conversation
- Bind comment-triggered dispatches to the PR head commit\n- Reject malformed commit inputs before checkout
sd-db
changed the title
Coverage report
This PR does not seem to contain any modification to coverable code. |
jprakash-db
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Maintainer approval for a fork pull request should authorize the exact commit that was reviewed. Previously, a contributor could push another commit after approval but before the privileged integration workflow checked out the pull request head.
This change captures the pull request head SHA when the integration command is accepted, passes that immutable SHA to both integration workflows, validates it before checkout, and reports the abbreviated SHA in the pull request status comment. Manual
git_ref, manual pull request number, scheduled, and minimum-dependency execution paths retain their existing behavior.Regression tests execute the embedded trigger and parser scripts to verify SHA capture and propagation, both workflow checkout targets, and rejection of malformed SHAs.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section. (Not applicable: CI-only change with no runtime behavior impact.)/dbt-databricks-pr-ready(AI agent skill in.claude/skills/) and addressed its merge-readiness feedbackVerification:
hatch run pytest tests/unit/test_integration_workflow_dispatch.py -v(5 passed)1284 passed, 6 skipped)hatch run pre-commit run --all-filesgit diff --check