Skip to content

Commit 6e31ad5

Browse files
ai: apply changes for #870 (2 review threads)
Addresses: - #3601040104 at .bot/prompts/engineer-followup/system.md:31 - #3601040111 at .bot/prompts/engineer/system.md:121 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent 55d1f12 commit 6e31ad5

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

.bot/prompts/engineer-followup/system.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,11 @@ Your job:
2828

2929
Repo facts you need:
3030
- `poetry`-managed, Python 3.8+; `poetry install --all-extras` has run on the
31-
runner, and the live-warehouse connection env is set — so both
32-
`poetry run python -m pytest tests/unit` (mocked) AND `tests/e2e` (live) are
33-
runnable. If a reviewer's ask is about connector behavior that only an E2E test
34-
can verify, add/adjust a `tests/e2e` test on the RIGHT backend for the change
35-
(Thrift default / `use_sea=True` / `use_kernel=True` — see CONTRIBUTING.md →
36-
"Backends and test tiers"), don't settle for a mocked unit test.
31+
runner, but this follow-up job wires NO live-warehouse connection env — so
32+
only `poetry run python -m pytest tests/unit` (fully mocked) runs here. Do
33+
NOT run or add `tests/e2e` (needs live credentials this job does not have).
34+
If a reviewer's ask can only be verified by an E2E test, say so and mark the
35+
thread blocked rather than adding an e2e test that cannot run here.
3736
- Source is under `src/databricks/sql/`; unit tests under `tests/unit/`.
3837
Follow `CONTRIBUTING.md`: PEP 8 with a 100-char line limit, type hints where
3938
the surrounding code uses them. This is a widely-consumed connector — keep

CONTRIBUTING.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,13 +146,14 @@ The suites marked `[not documented]` require additional configuration which will
146146

147147
#### Backends and test tiers
148148

149-
The connector has **two execution backends**, selected per connection. When you
149+
The connector has **three execution backends**, selected per connection. When you
150150
reproduce or fix a bug, use the backend the bug is actually on — a Thrift bug won't
151-
reproduce on a kernel connection, and vice versa:
151+
reproduce on a SEA or kernel connection, and vice versa:
152152

153153
| Backend | Select via (connect kwarg / `extra_params`) | Where its tests live |
154154
| --- | --- | --- |
155155
| **Thrift** (default) | *(nothing — the default path)* | the general `tests/e2e` suite (the `{}` parametrize case) and mocked `tests/unit` |
156+
| **SEA** (Statement Execution API) | `use_sea=True` | the general `tests/e2e` suite (the `{"use_sea": True}` parametrize case, e.g. `tests/e2e/test_driver.py`) and mocked `tests/unit` |
156157
| **Kernel** (Rust, optional) | `use_kernel=True` | the dedicated `tests/e2e/test_kernel_backend.py` / `test_kernel_tls.py`, plus the offline routing test `tests/unit/test_session.py -m realkernel` |
157158

158159
Notes that matter when running the suite:

0 commit comments

Comments
 (0)