Skip to content

Commit 55d1f12

Browse files
ai: apply changes for #870 (2 review threads)
Addresses: - #3600996714 at .github/workflows/engineer-bot.yml:200 - #3601002346 at CONTRIBUTING.md:156 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent c4e2dc0 commit 55d1f12

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

.bot/prompts/engineer/system.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,14 @@ selection than a single `-k` test — a whole file, or `tests/unit` — append
8989
the same `--all-extras` install). Skipping this produces a confusing false red
9090
that has nothing to do with your fix.
9191

92+
**Only the `default` schema is provisioned for this job.** The e2e connection env
93+
sets `DATABRICKS_SCHEMA` implicitly to `"default"` (it is intentionally left
94+
unset, mirroring `code-coverage.yml`, so the `schema` fixture falls back to
95+
`"default"`). Write your repro against the `default` schema — do NOT assume a
96+
seeded/non-default schema (e.g. staging-ingestion / UC-volume style tests, which
97+
also require `ingestion_user`), or the test will confusingly fail on a missing
98+
schema rather than on the bug.
99+
92100
**Always `-k`-filter to your own test** — do NOT run the whole `tests/e2e` suite:
93101
this job provides a live connection but does not seed the full per-run fixture set
94102
the broader suite expects, so unrelated E2E tests would fail or skip and that noise

CONTRIBUTING.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,22 +146,21 @@ The suites marked `[not documented]` require additional configuration which will
146146

147147
#### Backends and test tiers
148148

149-
The connector has **three execution backends**, selected per connection. When you
149+
The connector has **two execution backends**, selected per connection. When you
150150
reproduce or fix a bug, use the backend the bug is actually on — a Thrift bug won't
151151
reproduce on a kernel connection, and vice versa:
152152

153153
| Backend | Select via (connect kwarg / `extra_params`) | Where its tests live |
154154
| --- | --- | --- |
155155
| **Thrift** (default) | *(nothing — the default path)* | the general `tests/e2e` suite (the `{}` parametrize case) and mocked `tests/unit` |
156-
| **SEA** | `use_sea=True` | the general `tests/e2e` suite (the `{"use_sea": True}` parametrize case) |
157156
| **Kernel** (Rust, optional) | `use_kernel=True` | the dedicated `tests/e2e/test_kernel_backend.py` / `test_kernel_tls.py`, plus the offline routing test `tests/unit/test_session.py -m realkernel` |
158157

159158
Notes that matter when running the suite:
160159

161160
- **Kernel is an opt-in extra**, not part of the default install. `use_kernel=True`
162161
needs `pip install "databricks-sql-connector[kernel]"` (or `poetry install
163162
--all-extras`); without it the connector raises a clear "install the `[kernel]`
164-
extra" error. Most bugs are on the **Thrift/SEA** path — reproduce those there;
163+
extra" error. Most bugs are on the **Thrift** path — reproduce those there;
165164
only reach for kernel when the issue is specifically about `use_kernel`.
166165
- **`realkernel` tests must run in their own pytest invocation.** When the real
167166
kernel wheel is installed (`--all-extras`), several unit tests fake

0 commit comments

Comments
 (0)