Repository navigation
ci: apply engineer bot learnings from #565 and #567 - #572
Merged
Merged
Conversation
Read the PR branch tip in reviewer follow-ups, load .bot/ from main in engineer follow-ups, deny agent writes to .bot/, and merge main into bot PRs whose only conflict is new changelog entries. Tune the bot prompts for test level, fix choice, stale reviews and review scope, and record driver pitfalls for all bots. Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
vuanhphung
temporarily deployed
to
azure-prod
November 10, 2026 22:42 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 10, 2026 22:42 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 10, 2026 22:42 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the lessons from the engineer bot runs on #565 and #567 that don't need engine changes.
The reviewer follow-up checked out the commit from before each "Pushed " reply, so it reported pushed fixes as missing 12 times. It now reads the PR branch tip. Engineer follow-ups load
.bot/from main, and the agent can no longer write to.bot/, so a PR branch can't change its own allowlist or prompts. A new workflow merges main intoengineer-botPRs that start to conflict after a push to main: GitHub runs no PR workflows on a conflicting PR, which left #565 without bot responses for three days. Conflicts limited to new## Unreleasedentries are resolved by keeping both sides; others get a comment.The prompts now pick unit or e2e tests by whether the server can observe the bug, require each new test case to fail before the fix, prefer fixes that remove the cause, answer stale reviews with evidence, and keep pre-existing issues and repeated concerns out of review threads.
.claude/knowledge/driver-pitfalls.mdrecords contract and platform facts from both PRs for all bots.tsconfig.jsonmaps@databricks/sqltolib/sonpm run type-checkpasses.Testing
test_engineer_bot_sync.py, added to the lint job, covers changelog merging and branch syncing against a local repository with a fakegh. Type-check, prettier and YAML parsing pass. The workflows haven't run on GitHub yet.This pull request and its description were written by Isaac.