Throw SQLException for wrong complex-type getter calls#1561
Open
sreekanth-db wants to merge 1 commit into
Open
Throw SQLException for wrong complex-type getter calls#1561sreekanth-db wants to merge 1 commit into
sreekanth-db wants to merge 1 commit into
Conversation
Replace unchecked ClassCastException with DatabricksSQLException when getArray, getStruct, or getMap is called on a column of a different complex type, matching JDBC getter error handling. Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instanceofguards ingetArray,getStruct, andgetMapso a type mismatch throwsDatabricksSQLExceptionwith the existingCOMPLEX_DATA_TYPE_*_CONVERSION_ERRORSQLState instead of an uncheckedClassCastException.NULLhandling (still returnsnull) and existing disabled/inline-mode guards.testGetMapto mockDatabricksMap(the runtime type the driver returns).Test plan
mvn test -pl jdbc-core -Dtest=DatabricksResultSetTestDatabricksSQLExceptionwith correct SQLState; NULL array column still returnsnull