Improve SEA connection-failure error messages#1560
Open
sreekanth-db wants to merge 1 commit into
Open
Conversation
Include SDK error detail and HTTP status in buildErrorMessage so users see the server reason in getMessage(), not only in the nested cause. Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SEA connection failures (bad token, missing credential, non-existent warehouse, etc.) surfaced only a generic
Error while establishing a connection in databricksingetMessage(). The SDK already provides actionable detail (Invalid access token, HTTP status, etc.) butbuildErrorMessage()discarded it. Thrift already propagates server text into the message; this aligns SEA for HTTP API failures.DatabricksErrormessage and(HTTP status)inbuildErrorMessage()fallbackDatabricksExceptionpath)Testing
mvn test -pl jdbc-core -Dtest=DatabricksSdkClientTest#testCreateSessionWithNonSSLError,DatabricksSdkClientTest#testCreateSessionWithSSLCertificatePathErrorgetMessage()isaac review --uncommitted— APPROVE (0 actionable findings)Additional Notes to the Reviewer
Scope is intentionally minimal: one fallback return in
buildErrorMessage(). No change to unknown-host handling (DatabricksExceptionbypasses this path).