Repository navigation
Conversation
UC returns a catalog id (a UUID kept across renames, new on recreate) that the API spec and SDK do not declare. The catalog adapter now calls the catalogs API directly so it sees the id, records it in the state, and names it as the internal ID: the plan finds a catalog renamed out of band like it finds schemas and volumes. The test server returns and keeps the id too. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 28 not selected) 38 tests: regression=36 unreleased=0 coverage=2 failing=0
TestAccept/bundle/resources/catalogs/rename/DMS=: branch ✅ | main (77950b6) ❌ | latest (v1.25.0) ❌main (77950b6): latest (v1.25.0): TestAccept/bundle/resources/catalogs/rename/DMS=true: branch ✅ | main (77950b6) ❌ | latest (v1.25.0) ❌main (77950b6): latest (v1.25.0): TestAccept/bundle/resources/catalogs/rename_all_out_of_band/DMS=: branch ✅ | main (77950b6) ❌ | latest (v1.25.0) ❌main (77950b6): latest (v1.25.0): 33 more failure details omitted, see the full report in the run. |
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 0bb504d
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A catalog renamed outside the bundle is now found by its id, like schemas and volumes are found by
schema_id/volume_idin #7343. Before, the plan created it again under its new name, UC rejected the create withCATALOG_ALREADY_EXISTSon every deploy, and destroy left the catalog behind.UC returns an
idfor every catalog: a UUID that a rename keeps and a recreate changes (checked on AWS, Azure and GCP). The API spec does not declare it, so the SDK'sCatalogInfodrops it. The catalog adapter now makes the same calls the SDK makes, directly, decoding intoCatalogInfoplusid. The state records the id, andinternal_id_field: idlets the plan adopt the catalog only when its id matches. If UC ever stops returning the field, nothing is recorded and the plan falls back to today's behavior; it cannot adopt the wrong catalog.${resources.catalogs.<c>.id}still resolves to the catalog name.The test server returns an id for each catalog and keeps it across renames.
Stacked on #7381. Registered models and UC secrets return an
idtoo, so they can follow.Tests
catalogs/rename_out_of_bandandcatalogs/rename_all_out_of_band(Cloud = true): the plan now finds the catalog, the schema and the volume at their new names. The deploy sends no requests, destroy removes all three, and theBadnessboth tests had is gone.id, skipped in the plan with reasoninternal_id.Cloud = true(13) passes locally and on AWS, GCP and Azure; the invariant suite passes locally.This pull request and its description were written by Isaac.