Repository navigation
acc: redact ?w= workspace ID in default-python/combinations - #7416
Merged
Merged
Conversation
On cloud runs the acceptance harness passes the resolved workspace ID to the CLI as DATABRICKS_WORKSPACE_ID, so built-in templates now add ?w=<id> to the host. Strip it like integration_classic and other cloud tests do. Co-authored-by: Isaac <no-reply@databricks.com>
pietern
approved these changes
Nov 9, 2026
Collaborator
✅ Integration test reportCommit: c7ef052
Top 3 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Strip
?[ow]=[WORKSPACE_ID]from the output of thedefault-python/combinationstests, likeintegration_classicand other cloud tests already do.Why
After #7350, built-in templates add
?w=<id>to the host when the workspace ID comes from a profile or an env var. Cloud runs of the acceptance tests pass the workspace ID to the CLI asDATABRICKS_WORKSPACE_ID, so all 32 combinations print?w=and fail in the nightly runs. Local runs don't set it, so nothing changes there.Tests
The golden output doesn't change. A local run with
Env.DATABRICKS_WORKSPACE_IDset in test.toml (to mimic cloud) hits the same diff as the nightly without this change. The next nightly run is the real check. The?w=host itself is still pinned locally bydefault-minimal/profiles.This pull request and its description were written by Isaac.