Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 4 tests: regression=4 unreleased=0 coverage=0 failing=0
TestAccept/bundle/presets/name_prefix_reference_to_name/DMS=: branch ✅ | main (d3e5dde) ❌ | latest (v1.22.1) ❌main (d3e5dde): latest (v1.22.1): same output as main (d3e5dde) TestAccept/bundle/presets/name_prefix_reference_to_name/DMS=true: branch ✅ | main (d3e5dde) ❌ | latest (v1.22.1) ❌main (d3e5dde): latest (v1.22.1): same output as main (d3e5dde) TestAccept/bundle/resource_deps/resources_var_presets/DMS=: branch ✅ | main (d3e5dde) ❌ | latest (v1.22.1) ❌main (d3e5dde): latest (v1.22.1): same output as main (d3e5dde) TestAccept/bundle/resource_deps/resources_var_presets/DMS=true: branch ✅ | main (d3e5dde) ❌ | latest (v1.22.1) ❌main (d3e5dde): latest (v1.22.1): same output as main (d3e5dde) |
With presets.name_prefix "pre-", a job named "${resources.jobs.base.name}" ended
up as "pre-pre-base": the reference was prefixed and so was the referenced name.
Skip the prefix when the name is a pure reference to a name field that
ApplyPresets prefixes itself.
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…prefixed twice Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/fix-name-prefix-reference
branch
from
October 28, 2026 15:16
4679415 to
434f09a
Compare
shreyas-goenka
approved these changes
Oct 28, 2026
| "experiments": "name", | ||
| "model_serving_endpoints": "name", | ||
| "registered_models": "name", | ||
| "schemas": "name", |
Contributor
There was a problem hiding this comment.
note: this could be a breaking change for reosurces like schemas which refer by name. In practice this scenario should be fairly rare but lets call this out in our noteable changes section in the change log.
Collaborator
Integration test reportCommit: 092fce3
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ApplyPresetsleaves a name unprefixed when it is a pure reference to a name field thatApplyPresetsprefixes itself (prefixedNameFields: jobs/pipelines/...name, clusterscluster_name, dashboardsdisplay_name, ...; schemas only withoutexperimental.skip_name_prefix_for_schema). References to other fields (e.g..id) and non-pure strings ("${...} copy") are prefixed as before.Why
name: ${resources.jobs.base.name}withname_prefix: "pre-"resolved topre-pre-base([dev u] [dev u] basein development mode). The referenced value already carries the prefix (in normalized form for UC names), so the dev-mode marker is kept. Note: an already deployed resource with such a name is renamed on the next deploy.Port note: the fix lives in
bundle/config/mutator/resourcemutator/apply_presets.goand works on typed fields (not dyn-specific), so it ports as is.Tests
TestApplyPresetsNamePrefixReferenceToName.acceptance/bundle/presets/name_prefix_reference_to_name: nowpre-base, Badness removed.acceptance/bundle/resource_deps/resources_var_presets: schemafoonamed${resources.schemas.bar.name}is nowdev_<user>_myschemainstead ofdev_<user>_dev_<user>_myschema. Its name is now the same asbar's in the same catalog, as it already was without development mode.This pull request and its description were written by Isaac.