Repository navigation
Move the interactive device code login tests to the terminal emulator - #7222
Closed
maksim-zuev-db wants to merge 5 commits into
Closed
maksim-zuev-db wants to merge 5 commits into
maksim-zuev-db wants to merge 5 commits into
Conversation
Export RequestDeviceAuthorization and ExchangeDeviceCode so a login can be completed by a separate command, and rebuild DeviceCodeChallenge on top of them. Rejected codes now match ErrInvalidConfirmationCode or ErrInvalidDeviceCode, so callers no longer compare the server's description. Export NormalizeCode so that callers can compare codes the way the user enters them. Co-authored-by: Isaac <no-reply@databricks.com>
RequestDeviceAuthorization errors already say which step failed, and DeviceCodeChallenge adds the same prefix to its token exchange errors. Co-authored-by: Isaac <no-reply@databricks.com>
This was referenced Oct 28, 2026
Co-authored-by: Isaac <no-reply@databricks.com>
The acceptance tests of the interactive device code login pipe the confirmation code into stdin, while users type it into a terminal. Run the login in the terminal emulator against the fake server instead. The tests cover re-entering a wrong or blank code, running out of attempts, closed input, the stored token, and the scopes of the device authorization request. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: bcf2f96
Top 6 slowest tests (at least 2 minutes):
|
maksim-zuev-db
force-pushed
the
device-code-interactive-tests
branch
from
October 28, 2026 14:35
1d574cc to
fc8cd8d
Compare
Check the host, workspace ID, auth type and scopes of the saved profile instead of matching auth_type in the raw file. The scopes test now starts from an empty config with --host, so creating a profile from the flag is covered too. Clear the environment so DATABRICKS_* variables of the developer don't end up in the saved profile. Co-authored-by: Isaac <no-reply@databricks.com>
maksim-zuev-db
marked this pull request as ready for review
October 28, 2026 16:00
maksim-zuev-db
force-pushed
the
device-code-split-steps
branch
from
October 29, 2026 12:15
113e772 to
74b6992
Compare
Member
Author
|
Folded into #7220. The interactive login tests move to the terminal emulator in the same PR as the non-interactive login, because that is the change that stops piped stdin from testing the interactive flow. Until then, the refactoring in #7217 keeps the acceptance tests. This comment was written by Isaac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #7217.
Changes
The interactive device code login is now tested with
termtestagainst the fake server, instead of acceptance tests that pipe the confirmation code into stdin. Thedevice-code/nominalanddevice-code/wrong-codeacceptance tests are removed. No production code changes.Why
Users type the confirmation code into a terminal, and the upcoming non-interactive login (#7220) takes over when stdin is not a terminal, so the piped tests would stop testing the interactive flow.
Tests
The new tests cover re-entering a wrong or blank code, running out of attempts, closed input, the stored token, and the scopes of the device authorization request.
This pull request and its description were written by Isaac.