Repository navigation
Auto-complete reviewed SDK field copies during bumps - #7158
Open
janniklasrose wants to merge 2 commits into
Open
janniklasrose wants to merge 2 commits into
janniklasrose wants to merge 2 commits into
Conversation
Collaborator
Integration test reportCommit: 6152392
Top 3 slowest tests (at least 2 minutes):
|
janniklasrose
force-pushed
the
janniklasrose/sdk-field-copies
branch
from
October 22, 2026 07:30
b2b1a00 to
13997b3
Compare
Add an opt-in source fixer for missing direct-resource fields and run it before the SDK bump's generators. Require matching Go names, JSON names, and exact types; preserve existing mappings and type-check proposed edits before writing them. Audit every direct-resource family, annotate 26 copy sites, and document the selective and mixed-source mappings that still require review. Cover the inference boundaries with fixtures and replay the six warehouse field copies from SDK bump #7155.
janniklasrose
force-pushed
the
janniklasrose/sdk-field-copies
branch
from
October 23, 2026 11:54
13997b3 to
1150b96
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Run
fix-sdk-field-copiesat the start ofbump-sdk-post. Explicit// sdk:copy-from sourceannotations opt 26 audited struct literals into completing missing fields with the same Go name, JSON name, and exact type. Preserve existing mappings and type-check all proposed edits before writing. The tool's README records the audit and exclusions for every direct-resource family.Why
SDK additions such as the warehouse fields in #7155 currently need manual exhaustruct fixes. A reviewed annotation establishes which source owns future fields; type checking verifies the copy mechanics. Selective bodies, mixed-source mappings, metadata, conversions, and unmatched fields remain manual.
SDK field removals are breaking changes and intentionally require manual handling. If a removed field is still referenced in the direct-resource package or its dependencies, the fixer's initial type-check fails loudly before any files are written. It does not delete assignments or guess replacements.
Tests
This PR was written by Codex.