Skip to content

Use synctest.Sleep in SSH tests - #7118

Open
pietern wants to merge 1 commit into
mainfrom
go127-synctest-sleep
Open

pietern wants to merge 1 commit into
mainfrom
go127-synctest-sleep

Conversation

@pietern

@pietern pietern commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Replace time.Sleep(d) followed by synctest.Wait() with synctest.Sleep(d) (Go 1.27) at the 26 places in the experimental/ssh tests where they appear together.

This pull request and its description were written by Isaac.

Go 1.27 adds synctest.Sleep, which is equivalent to time.Sleep followed
by synctest.Wait.

Co-authored-by: Isaac <no-reply@databricks.com>
@pietern
pietern marked this pull request as ready for review October 20, 2026 10:01
@pietern
pietern requested review from a team as code owners October 20, 2026 10:01
@pietern
pietern enabled auto-merge October 20, 2026 10:01
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: cefc748

Run: 39403524768

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 280 15 4:01
✅​ aws-windows-latest-4core-16gb 282 13 3:16
✅​ azure linux-2core-8gb 279 15 4:06
✅​ azure-windows-latest-4core-16gb 281 13 3:14
✅​ gcp linux-2core-8gb 280 15 3:56
✅​ gcp-windows-latest-4core-16gb 282 13 3:00
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:08 azure-windows-latest-4core-16gb TestAccept
2:53 gcp-windows-latest-4core-16gb TestAccept
2:52 aws-windows-latest-4core-16gb TestAccept

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants