Skip to content

direct: add a Bind plan action - #7110

Closed
shreyas-goenka wants to merge 1 commit into
mainfrom
isaac/dmsbind-plan-action
Closed

shreyas-goenka wants to merge 1 commit into
mainfrom
isaac/dmsbind-plan-action

Conversation

@shreyas-goenka

Copy link
Copy Markdown
Contributor

Changes

Adds a Bind plan action to the direct engine. When DeploymentBundle.BindKey names a resource, CalculatePlan reads it by BindID instead of its state entry and plans Bind; apply records it in state with no API call (the next deploy applies config differences). A bound resource's ${...id} resolves from its plan entry.

Why

First step of moving bundle deployment bind onto a planned action, so the same flow can record a bind with the deployment metadata service. Nothing sets BindKey yet.

Tests

Unit test for the id lookup; existing suites unchanged.

This pull request and its description were written by Isaac.

CalculatePlan can now adopt an existing workspace resource: when
DeploymentBundle.BindKey names a resource, it is read by BindID instead of its
state entry and planned as Bind. Apply records it in state without an API
write, taking the id from the plan entry because the resource is not in state
yet; the next deploy applies any config differences. Nothing sets BindKey yet;
DMS bind uses it in a follow-up.

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot added the DABs DABs related issues label Oct 19, 2026
@shreyas-goenka
shreyas-goenka added this pull request to stack #7114 October 19, 2026 15:52
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 8afba87

Run: 39281440757

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 276 15 5:40
✅​ aws-windows-latest-4core-16gb 278 13 4:04
✅​ azure linux-2core-8gb 275 15 5:41
✅​ azure-windows-latest-4core-16gb 277 13 4:05
✅​ gcp linux-2core-8gb 276 15 5:40
✅​ gcp-windows-latest-4core-16gb 278 13 6:11
Top 6 slowest tests (at least 2 minutes):
duration env testname
6:04 gcp-windows-latest-4core-16gb TestAccept
3:59 azure-windows-latest-4core-16gb TestAccept
3:57 aws-windows-latest-4core-16gb TestAccept
3:47 gcp linux-2core-8gb TestAccept
3:42 azure linux-2core-8gb TestAccept
3:36 aws linux-2core-8gb TestAccept

@shreyas-goenka
shreyas-goenka removed this pull request from stack #7114 October 20, 2026 13:30
@shreyas-goenka

Copy link
Copy Markdown
Contributor Author

Superseded by #7127, which registers the bind in its own DMS version without a new plan action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants