Skip to content

genie_spaces: Stop allowing Sequence types for serialized_space #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janniklasrose merged 1 commit into from
Sep 3, 2026
Merged

genie_spaces: Stop allowing Sequence types for serialized_space #6491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions bundle/config/mutator/resourcemutator/configure_genie_space_serialized_space.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ func (c configureGenieSpaceSerializedSpace) Apply(_ context.Context, b *bundle.B
// KindInvalid means serialized_space is absent (neither it nor
// file_path is set); leave it for backend validation to reject.
return v, nil
case dyn.KindMap, dyn.KindSequence:
case dyn.KindMap:
// A top-level sequence would be valid JSON but is meaningless for a
// genie space, so KindSequence is not accepted here and falls through
// to the default rejection below.
jsonBytes, err := json.Marshal(ss.AsAny())
if err != nil {
return dyn.InvalidValue, fmt.Errorf("failed to marshal inline serialized_space: %w", err)
Expand All @@ -74,7 +77,7 @@ func (c configureGenieSpaceSerializedSpace) Apply(_ context.Context, b *bundle.B
default:
diags = diags.Append(diag.Diagnostic{
Severity: diag.Error,
Summary: fmt.Sprintf("serialized_space must be a string, map, or sequence, got %s", ss.Kind()),
Summary: fmt.Sprintf("serialized_space must be a string or map, got %s", ss.Kind()),
Locations: ss.Locations(),
})
return v, nil
Expand Down
10 changes: 9 additions & 1 deletion bundle/config/mutator/resourcemutator/configure_genie_space_serialized_space_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,15 @@ func TestConfigureGenieSpaceSerializedSpace(t *testing.T) {
name: "non-structured serialized_space is rejected",
setSerialized: true,
serializedSpace: true,
wantErr: "serialized_space must be a string, map, or sequence, got bool",
wantErr: "serialized_space must be a string or map, got bool",
},
{
// A top-level sequence is valid JSON but meaningless for a genie space,
// so it is rejected rather than marshaled like an inline map.
name: "inline sequence is rejected",
setSerialized: true,
serializedSpace: []any{map[string]any{"version": 1}},
wantErr: "serialized_space must be a string or map, got sequence",
},
{
name: "unreadable file_path is an error",
Expand Down
Loading