-
Notifications
You must be signed in to change notification settings - Fork 222
aitools: add --output json to install #6481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rclarey
wants to merge
1
commit into
main
Choose a base branch
from
aitools-install-output-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| `databricks aitools install` honors `--output json`, emitting a structured `{scope, agents[...]}` document that reports each agent's delivery and install status so coding agents and CI can consume the result without scraping the text output. JSON mode requires `--scope` and `--agents` so the command runs without interactive prompts ([#6481](https://github.com/databricks/cli/pull/6481)). |
2 changes: 2 additions & 0 deletions
2
acceptance/experimental/aitools/skills/install-output-json/out.test.toml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
17 changes: 17 additions & 0 deletions
17
acceptance/experimental/aitools/skills/install-output-json/output.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
|
|
||
| === install --output json emits parseable JSON on stdout; progress stays on stderr | ||
| >>> [CLI] experimental aitools install --skills-only --scope=global --agents=claude-code --output json | ||
| Command "install" is deprecated, use "databricks aitools install" instead. | ||
| Using skills version test-ref | ||
| Fetching skills manifest... | ||
| Installed 1 skill. | ||
| { | ||
| "scope": "global", | ||
| "agents": [ | ||
| { | ||
| "name": "claude-code", | ||
| "delivery": "skills", | ||
| "status": "installed" | ||
| } | ||
| ] | ||
| } |
9 changes: 9 additions & 0 deletions
9
acceptance/experimental/aitools/skills/install-output-json/script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Isolate HOME so parallel aitools tests don't race on a shared ~/.databricks. | ||
| sethome home | ||
|
|
||
| title "install --output json emits parseable JSON on stdout; progress stays on stderr" | ||
| # --agents makes the run fully non-interactive (no picker, no scope prompt), which | ||
| # --output json requires. Piping stdout through jq proves the JSON payload is the | ||
| # only thing on stdout; the human-readable progress lines go to stderr and still | ||
| # show in the merged capture below. | ||
| trace $CLI experimental aitools install --skills-only --scope=global --agents=claude-code --output json | jq . |
35 changes: 35 additions & 0 deletions
35
acceptance/experimental/aitools/skills/install-output-json/test.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Mock server replaces raw.githubusercontent.com for manifest + skill files. | ||
| Env.DATABRICKS_SKILLS_BASE_URL = "$DATABRICKS_HOST" | ||
| Env.DATABRICKS_SKILLS_REF = "test-ref" | ||
|
|
||
| Ignore = [ | ||
| "home", | ||
| ] | ||
|
|
||
| EnvMatrix.DATABRICKS_BUNDLE_ENGINE = ["direct"] | ||
|
|
||
| [[Server]] | ||
| Pattern = "GET /test-ref/manifest.json" | ||
| Response.Body = ''' | ||
| { | ||
| "version": "2", | ||
| "updated_at": "2026-01-01T00:00:00Z", | ||
| "skills": { | ||
| "test-stable": { | ||
| "version": "1.0.0", | ||
| "description": "Stable test skill", | ||
| "files": ["SKILL.md"], | ||
| "repo_dir": "skills" | ||
| } | ||
| } | ||
| } | ||
| ''' | ||
|
|
||
| [[Server]] | ||
| Pattern = "GET /test-ref/skills/test-stable/SKILL.md" | ||
| Response.Body = '''--- | ||
| name: test-stable | ||
| --- | ||
|
|
||
| # Test stable skill | ||
| ''' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nice to have] This duplicates
root.OutputType(cmd), which the siblinglist.go:141already uses. Thef == nilfallback is dead in production —--outputis always a persistent root flag — and is the kind of speculative/defensive branch CLAUDE.md asks us to drop. Preferroot.OutputType(cmd) == flags.OutputJSONfor consistency withlist.