feat(appkit): auto-start app under test for agent evals (stack 6/6)#482
Open
MarioCadenas wants to merge 1 commit into
Open
feat(appkit): auto-start app under test for agent evals (stack 6/6)#482MarioCadenas wants to merge 1 commit into
MarioCadenas wants to merge 1 commit into
Conversation
Add a Playwright-style `webServer` so `appkit agent eval` can boot the app
itself instead of requiring a server to be running.
- Root `evals.config.ts` (project root, via defineEvalConfig) carries run-wide
settings: `baseUrl` + `webServer { command, url?, timeoutMs?, reuseExisting? }`.
appkit exposes `loadRootEvalConfig` / `findRootEvalConfig`; the per-agent
config keeps its narrow maxConcurrency/timeoutMs role.
- CLI resolves baseUrl/concurrency/timeout as flag > root config > default, and
before running: reuses a server already answering at `url` (default) or spawns
`command`, polls until any HTTP response or timeout, then SIGTERMs the process
group in a finally. A reused server is left untouched.
- `--url` default changed 3000 → 8000 (the port these apps actually use).
Verified end-to-end against dev-playground: cold start boots + tears down; warm
start reuses and leaves the dev server running.
Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 6/6 · targets
pr/agent-evals-5-docs(review after #481).Playwright-style auto-start for the app under test, so
appkit agent evalno longer requires a manually-started server.evals.config.ts(project root, viadefineEvalConfig) carries run-wide settings —baseUrlandwebServer { command, url?, timeoutMs?, reuseExisting? }— plus defaults formaxConcurrency/timeoutMs.loadRootEvalConfig/findRootEvalConfigexposed from@databricks/appkit/beta. The per-agentevals.config.tskeeps its narrow role (additive — nothing removed).baseUrl/concurrency/timeout as flag > root config > default; before running, reuses a server already answering aturl(default) or spawnscommand, polls until any HTTP response or timeout, then SIGTERMs the process group in afinally. A reused server is left running.--urldefault3000→8000(the port these apps actually serve on).Design was grilled to resolve scope (root config, spawn in CLI not the library, readiness = any HTTP response, reuse-existing default true). Verified end-to-end against dev-playground: cold start boots + tears down; warm start reuses and leaves the dev server up.