ci: run apps/dashboard's own typecheck + tests in CI - #191
Open
kevin-hartman wants to merge 1 commit into
Open
Conversation
Root `npm test` covers tests/** only; the vendored apps/dashboard has its own package.json + vitest (~401 tests) that no CI job ran. Add a `dashboard` job (npm ci + tsc --noEmit + vitest run, working-directory apps/dashboard) so dashboard changes are gated on the dashboard's own suite. Runs on pull_request/push to main alongside build-and-test; npm ci relies on the now-public apps/dashboard lockfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
dashboardjob to.github/workflows/ci.ymlso the vendoredapps/dashboardapp is gated on its own suite.Why
Root
npm testruns vitest overtests/**only — it never installsapps/dashboarddeps or runs the app's ~401 vitest tests or itstsc --noEmit, so a dashboard change could regress with a green root CI. This is the coverage gap surfaced during the #190 review.What the job does
npm ci+npx tsc --noEmit+npx vitest run,working-directory: apps/dashboard, onpull_request/pushtomainalongsidebuild-and-test.npm cirelies on the now-publicapps/dashboard/package-lock.json.This PR's own CI run exercises the new job.