Skip to content

Upgrade netty version #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sidhdirenge wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Upgrade netty version #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions adls-plugins/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@
<artifactId>adls-plugins</artifactId>

<dependencies>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty</artifactId>
<version>${netty.version}</version>
</dependency>
Comment on lines +31 to +35

@gemini-code-assist gemini-code-assist Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

Hardcoding dependency versions in child modules reduces maintainability and can lead to version mismatch issues across the project. It is highly recommended to define the version in the parent pom.xml (either under properties or dependencyManagement) and reference it here using a property.

Additionally, Netty 3.9.9.Final is an extremely old version with multiple known security vulnerabilities (CVEs). If a 3.x version is strictly required due to legacy dependencies, please consider upgrading to at least 3.10.6.Final. Otherwise, upgrading to a supported 4.x version is strongly recommended.

Suggested change
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty</artifactId>
<version>3.9.9.Final</version>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty</artifactId>
<version>${netty.version}</version>
</dependency>

<dependency>
<groupId>org.apache.avro</groupId>
<artifactId>avro-mapred</artifactId>
Expand Down
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
<app.parents>
system:cdap-data-pipeline[6.11.0-SNAPSHOT,7.0.0-SNAPSHOT),system:cdap-data-streams[6.11.0-SNAPSHOT,7.0.0-SNAPSHOT)
</app.parents>
<netty.version>3.10.6.Final</netty.version>
<main.basedir>${project.basedir}</main.basedir>
</properties>

Expand Down
Loading