Make the full test suite runnable - #2
Open
asp24 wants to merge 1 commit into
Open
Conversation
`go test ./...` fails on master: TestNdjsonCountWhere2 dies with a nil pointer dereference inside loadFile. Two of the corpora fetched on demand answer 404 now, and the error path calls err.Error() on the nil error http.Get returns when the request itself succeeded and only the status was bad. loadFile now takes a testing.TB and skips the caller when a corpus cannot be obtained - there is nothing wrong with the code under test - while a corrupt archive or an unwritable cache stays fatal. It also closes the response body, which it never did. .gitignore was absent, so the corpora the tests download appear as untracked files; it now covers those, test binaries and profiling output. Test files and .gitignore only; no change to the library.
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Candidate for
minio/simdjson-go. Cut from upstream master, nothing fork-specific in it.go test ./...fails on upstream master today:TestNdjsonCountWhere2panics with a nil pointer dereference inloadFile. Two of the corpora it fetches on demand (parking-citations-1M.json.zst,RC_2009-01.json.zst) answer 404, and the error path callserr.Error()on the nil errorhttp.Getreturns when the request succeeded and only the status was bad. Upstream CI last ran on 2025-08-26 and was green, which is why nobody noticed.loadFilenow takes atesting.TBand skips its caller when a corpus cannot be obtained, while a corrupt archive or an unwritable cache stays fatal. The response body gets closed, which it never was.Test files and
.gitignoreonly; the library is untouched.About the red CI here.
TestandTest Noasmpass in every cell of upstream's matrix. The one cell that fails is1.22.x+macos-latest, in the-racestep, before any test runs:dyld: missing LC_UUID load command- that toolchain against the current macOS runner image. The same commit passes the same step on1.23.xand1.24.xmacOS, so it is the cell and not the code;fail-fastthen cancels the rest of the matrix, which is what the other red marks are.