TST: unskip test_from_dlpack (was a temporary skip) - #230
Merged
Conversation
lucascolley
approved these changes
Jul 27, 2026
lucascolley
requested changes
Jul 27, 2026
lucascolley
left a comment
lucascolley
left a comment
Member
There was a problem hiding this comment.
hmm looks like this still fails with NumPy <2
FAILED array_api_tests/test_dlpack.py::test_from_dlpack - TypeError: numpy.from_dlpack() takes no keyword arguments
ev-br
force-pushed
the
unskip_test_from_dlpack
branch
from
July 27, 2026 13:55
bd022ce to
9d5eb67
Compare
Member
Author
|
Such are the joys. Updated with a more appropriate comment in the skip file. |
Member
Author
|
gentle ping @lucascolley : good to go now? The test is still skipped, just with a less wrong comment |
lucascolley
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.