Skip to content

fix(dash-spv): only re-export request_keys where the mock network uses it - #1245

Merged
ZocoLini merged 1 commit into
devfrom
fix/request-keys-unused-import
Oct 28, 2026
Merged

ZocoLini merged 1 commit into
devfrom
fix/request-keys-unused-import

Conversation

@ZocoLini

@ZocoLini ZocoLini commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 Generated with Claude Code

PR Hygiene · 8ea48f5

  • Bots — coderabbitai not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — post /self-reviewed
  • Build running
  • Approvals
    • dash-spv (dash-spv/src/network/mod.rs) — QuantumExplorer or xdustinface

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

…s it

Only test_utils uses the re-export, so the default-features clippy pass flags it as unused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0470e6e and 8ea48f5.

Files selected for processing: 1
  • dash-spv/src/network/mod.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Oct 28, 2026
@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.88%. Comparing base (0470e6e) to head (8ea48f5).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1245   +/-   ##
=======================================
  Coverage   78.88%   78.88%           
=======================================
  Files         298      298           
  Lines       79025    79025           
=======================================
+ Hits        62338    62339    +1     
+ Misses      16687    16686    -1     
Flag Coverage Δ
core 77.85% <ø> (ø)
ffi 51.60% <ø> (+<0.01%) ⬆️
rpc 52.05% <ø> (ø)
spv 93.49% <ø> (ø)
wallet 82.53% <ø> (ø)
Files with missing lines Coverage Δ
dash-spv/src/network/mod.rs 97.36% <ø> (ø)

... and 4 files with indirect coverage changes

@ZocoLini

Copy link
Copy Markdown
Collaborator Author

@coderabbitai approve

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Comments resolved and changes approved.

@ZocoLini
ZocoLini merged commit 50a97a3 into dev Oct 28, 2026
38 of 39 checks passed
@ZocoLini
ZocoLini deleted the fix/request-keys-unused-import branch October 28, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant